Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force black to use the pytoml file as configuration. #4588

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Apr 1, 2024

Some downstream repositories do not seem to pick up the right black configuration. This can happen with out-of-tree builds. Unclear why for me.

Forcing the configuration path fixes this problem.

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label Apr 1, 2024
@fruffy fruffy changed the title Force black to use pytoml as config. Force black to use pytoml as configuration. Apr 1, 2024
@fruffy fruffy changed the title Force black to use pytoml as configuration. Force black to use the pytoml file as configuration. Apr 1, 2024
@fruffy fruffy marked this pull request as ready for review April 2, 2024 13:48
@fruffy fruffy requested a review from vlstill April 2, 2024 20:55
@fruffy fruffy enabled auto-merge April 3, 2024 13:22
@fruffy fruffy requested a review from jafingerhut April 10, 2024 18:46
@fruffy
Copy link
Collaborator Author

fruffy commented Apr 16, 2024

@jafingerhut @vlstill Could you give this a quick review? We have some downstream repositories' lint CI failing because of this problem.

Copy link
Contributor

@vlstill vlstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not very familiar with black this seems innocent enough to approve.

@fruffy fruffy added this pull request to the merge queue Apr 16, 2024
Merged via the queue into main with commit e11b629 Apr 16, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/black_config branch April 16, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants