Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Comment Style Guide #4573

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

AdarshRawat1
Copy link
Member

@AdarshRawat1 AdarshRawat1 commented Mar 28, 2024

Fixes Issue -

Based on discussion

Task done

  • Added guidelines on the commenting style convention to be used for documenting the codebase
  • Linked the commenting style guide with the coding convention section

Follow-up Discussion

Should wo include this section somewhere around the Coding Conventions section

- Improved Description of Comment Style 
- linked comment style to Coding conventions
@fruffy fruffy added the documentation Topics related to compiler documentation. label Mar 29, 2024
Copy link
Collaborator

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Maybe we should hint at this style guide in the top-level README, too.

@AdarshRawat1
Copy link
Member Author

AdarshRawat1 commented Mar 29, 2024

Looks good, thanks!

Thank you Sir.

Maybe we should hint at this style guide in the top-level README, too.

What would be the optimal approach for that?

  1. Add it under the Source File section

  2. Shift How to Contribute section to top level README file and then adding the link to all resources under it.

This way we can link the commenting guides, Unit testGuides, Documentation and coding guides at one place for easy access

p4c/docs/README.md

Lines 89 to 95 in f8df27f

# How to contribute
* do write unit test code
* code has to be reviewed before it is merged
* make sure all tests pass when you send a pull request
* make sure `make cpplint` produces no errors (`make check` will also run this)
* write documentation

  1. We can either place it under the Development tools.

But it already has a link to the README file containing all the guides

@fruffy fruffy added this pull request to the merge queue Mar 30, 2024
@fruffy
Copy link
Collaborator

fruffy commented Mar 30, 2024

"How to contribute" should definitely be more prominent at the top-level. I will merge this but feel free to do a follow-up, if you would like to.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2024
@fruffy fruffy added this pull request to the merge queue Mar 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2024
@AdarshRawat1
Copy link
Member Author

"How to contribute" should definitely be more prominent at the top-level.

Then, I'll shift it to the top level.

I will merge this but feel free to do a follow-up, if you would like to.

I'll submit a follow-up PR by EOD.

@fruffy fruffy added this pull request to the merge queue Apr 1, 2024
@fruffy fruffy changed the title [docs] Add Comment Style Guide Add Comment Style Guide Apr 1, 2024
@fruffy fruffy changed the title Add Comment Style Guide [docs] Add Comment Style Guide Apr 1, 2024
Merged via the queue into p4lang:main with commit 0657480 Apr 1, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Topics related to compiler documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants