-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Comment Style Guide #4573
[docs] Add Comment Style Guide #4573
Conversation
- Improved Description of Comment Style - linked comment style to Coding conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Maybe we should hint at this style guide in the top-level README, too.
Thank you Sir.
What would be the optimal approach for that?
This way we can link the commenting guides, Unit testGuides, Documentation and coding guides at one place for easy access Lines 89 to 95 in f8df27f
But it already has a link to the README file containing all the guides |
"How to contribute" should definitely be more prominent at the top-level. I will merge this but feel free to do a follow-up, if you would like to. |
Then, I'll shift it to the top level.
I'll submit a follow-up PR by EOD. |
Fixes Issue -
Based on discussion
Task done
Follow-up Discussion
Should wo include this section somewhere around the Coding Conventions section