Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Arithmetic operations for fields which are in network order #4566

Merged
merged 25 commits into from
Apr 2, 2024

Conversation

komaljai
Copy link
Contributor

Handle Arithmetic operations for fields which are in network order(annotated in header definition, action parameters and table keys)

Stop conversion of header fields in deparser.
Handle network oeder and host order operations in C Program
backends/ebpf/target.h Outdated Show resolved Hide resolved
@fruffy fruffy added p4tc Topics related to the P4-TC back end run-sanitizer Use this tag to run a Clang+Sanitzers CI run. labels Mar 27, 2024
Copy link
Contributor

@maheswari-s maheswari-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

Copy link
Contributor

@usha1830 usha1830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have a few comments/queries. Please check

testdata/p4tc_samples_outputs/checksum_parser.c Outdated Show resolved Hide resolved
backends/ebpf/codeGen.cpp Outdated Show resolved Hide resolved
backends/ebpf/codeGen.cpp Outdated Show resolved Hide resolved
@usha1830 usha1830 added this pull request to the merge queue Apr 2, 2024
Merged via the queue into p4lang:main with commit e86bac6 Apr 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tc Topics related to the P4-TC back end run-sanitizer Use this tag to run a Clang+Sanitzers CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants