[P4Testgen] Clean up the direct extern map implementation for BMv2. #4546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fruffy-g
commented
Mar 18, 2024
fruffy-g
commented
- Use cstring instead of the declaration pointer in the direct extern map.
- Check for all implementations.
- Create an explicit static array of implementations.
jonathan-dilorenzo
approved these changes
Mar 25, 2024
backends/p4tools/modules/testgen/targets/bmv2/map_direct_externs.h
Outdated
Show resolved
Hide resolved
backends/p4tools/modules/testgen/targets/bmv2/map_direct_externs.cpp
Outdated
Show resolved
Hide resolved
fruffy-g
force-pushed
the
fruffy/direct_extern_map
branch
from
f8acf3c
to
642aaff
Compare
…ap. Check for all implementations.
auto-merge was automatically disabled
March 25, 2024 18:24
Head branch was pushed to by a user without write access
fruffy-g
force-pushed
the
fruffy/direct_extern_map
branch
from
642aaff
to
8194206
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.