Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend parser to allow parentheses in lvalues #4530

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Extend parser to allow parentheses in lvalues #4530

merged 3 commits into from
Mar 14, 2024

Conversation

jnfoster
Copy link
Contributor

@fruffy
Copy link
Collaborator

fruffy commented Mar 13, 2024

The test is failing because it is missing the reference files. You can generate these files with
P4TEST_REPLACE=True ctest -R p4/testdata/p4_16_samples/lvalue-parens.p4

@jnfoster
Copy link
Contributor Author

Yup. Thanks. Will fix soon.

@fruffy fruffy added the p4-spec Topics related to the P4 specification (https://github.com/p4lang/p4-spec/). label Mar 13, 2024
@jnfoster jnfoster requested a review from ChrisDodd March 13, 2024 19:40
@jnfoster jnfoster added this pull request to the merge queue Mar 14, 2024
Merged via the queue into p4lang:main with commit 7906663 Mar 14, 2024
17 checks passed
@jnfoster jnfoster deleted the allow-parens-in-lvalues branch March 14, 2024 13:47
vgurevich added a commit to vgurevich/p4-spec that referenced this pull request Mar 17, 2024
@vgurevich
Issue p4lang#1273
315b64a 
Added the definition allowing parentheses around lvalues to the grammar,
similar to what was done in p4lang/p4c#4530.

In addition to that performed a minor cleanup, replacing the (copied)
grammar code with the proper INCLUDE.
@vgurevich vgurevich mentioned this pull request Mar 17, 2024
Merged
jnfoster pushed a commit to jnfoster/p4-spec that referenced this pull request Jun 3, 2024
@vgurevich @jnfoster
Issue p4lang#1273
e6f051e 
Added the definition allowing parentheses around lvalues to the grammar,
similar to what was done in p4lang/p4c#4530.

In addition to that performed a minor cleanup, replacing the (copied)
grammar code with the proper INCLUDE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruffy fruffy fruffy approved these changes

@ChrisDodd ChrisDodd Awaiting requested review from ChrisDodd

Assignees
No one assigned
Labels
p4-spec Topics related to the P4 specification (https://github.com/p4lang/p4-spec/).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L-Value Syntax
2 participants
@jnfoster @fruffy