Update formatters (clang-format, isort, black) #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/clang-format
branch
from
9f6bff8
to
21c6f7b
Compare
fruffy
force-pushed
the
fruffy/clang-format
branch
from
21c6f7b
to
ec1ae92
Compare
fruffy
commented
Mar 8, 2024
| while (find_next(k, &cache)) | ||
| ; | ||
| else | ||
| if (info->ismulti) { |
There was a problem hiding this comment.
These changes are a little funky, I believe explicit brackets make the intent clearer.
fruffy
added
the
infrastructure
asl
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a while since we have last updated the formatters. clang-format in particular has implemented a variety of changes.