gc: implement posix_memalign #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
force-pushed
the
cdodd-memalign
branch
from
39dc31f
to
209d6da
Compare
fruffy
approved these changes
Mar 7, 2024
vlstill
approved these changes
Mar 7, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ChrisDodd
force-pushed
the
cdodd-memalign
branch
from
209d6da
to
ef3b499
Compare
vlstill
reviewed
Mar 8, 2024
lib/gc.cpp
Outdated
| @@ -262,6 +262,12 @@ void *calloc(size_t size, size_t elsize) { | |||
| if (rv) memset(rv, 0, size); | |||
| return rv; | |||
| } | |||
| int posix_memalign(void **memptr, size_t alignment, size_t size) throw() { | |||
There was a problem hiding this comment.
throw() should be equivalent to noexcept in C++17 and will be dropped in C++20.
But sadly it seems like the exception spec will need to be os-dependent :-(.
ChrisDodd
force-pushed
the
cdodd-memalign
branch
4 times, most recently
from
9342a72
to
76450f0
Compare
fruffy
added
the
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case any backend wants to use this function.