Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Bazel badge in the Bazel README section to the actual CI test #4505

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Sanket-0510
Copy link
Contributor

The link to the bazel build is broken or rather it is not provided, I have added the right link for the same.

@fruffy
Copy link
Collaborator

fruffy commented Mar 6, 2024

That's a funny one, thanks for spotting it. Can you please make the pull request title more precise? Describe more clearly what broken link is fixed here.

Then we can merge this one.

@Sanket-0510 Sanket-0510 changed the title fix the broken link The image shall redirect to bazel build workflow Mar 6, 2024
@Sanket-0510
Copy link
Contributor Author

That's a funny one, thanks for spotting it. Can you please make the pull request title more precise? Describe more clearly what broken link is fixed here.

Then we can merge this one.

Hey @fruffy the given image is supposed to be link for the bazel build
like these one -
https://github.com/p4lang/p4c/blob/0685e1a00c899a54d719ff67cd4b5f0a551e8778/README.md?plain=1#L1C1-L5C1

I know this is silly but I just spotted it and thought it can be fixed, pardon me if that is not the expected behaviour for the same

@fruffy fruffy changed the title The image shall redirect to bazel build workflow Link Bazel badge in the Bazel README section to the actual CI test Mar 6, 2024
@fruffy
Copy link
Collaborator

fruffy commented Mar 6, 2024

Thanks! On naming your pull requests and commits I would recommend following conventions such as the imperative style. I edited the title with an example of how to do this.

There are some guides out there, for example:
https://cbea.ms/git-commit/
https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

These guidelines are not mandatory, for example I prefer to use periods, but are good to keep in mind.

@Sanket-0510
Copy link
Contributor Author

Thanks! On naming your pull requests and commits I would recommend following conventions such as the imperative style. I edited the title with an example of how to do this.

There are some guides out there, for example: https://cbea.ms/git-commit/ https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

These guidelines are not mandatory, for example I prefer to use periods, but are good to keep in mind.

thanks for this @fruffy I will make sure to follow these from next time

@fruffy fruffy added this pull request to the merge queue Mar 7, 2024
Merged via the queue into p4lang:main with commit c3c462d Mar 7, 2024
17 checks passed
@fruffy fruffy added the documentation Topics related to compiler documentation. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Topics related to compiler documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants