Add support for parser errors in tc backend #4443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this is breaking the ebpf backend in some cases. |
vbnogueira
force-pushed
the
tc-parse-error-support
branch
2 times, most recently
from
d4b64b9
to
fc7043d
Compare
Fixed and pushed |
vbnogueira
force-pushed
the
tc-parse-error-support
branch
from
fc7043d
to
2e7a19c
Compare
usha1830
reviewed
Feb 22, 2024
usha1830
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for parser errors in tc backend and also try to handle pna_main_input_metadata_t fields better by rejecting programs that use unsupported fields