[P4Testgen] Add an option to only generate tests with dropped packets. #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
changed the title
fruffy
force-pushed
the
fruffy/testgen_library_api
branch
from
b8faee2
to
6544bdb
Compare
fruffy
force-pushed
the
fruffy/testgen_dropped_packet_only
branch
from
0a1148a
to
e8907a7
Compare
fruffy
force-pushed
the
fruffy/testgen_library_api
branch
4 times, most recently
from
7ab31fa
to
94feeaf
Compare
fruffy
force-pushed
the
fruffy/testgen_dropped_packet_only
branch
3 times, most recently
from
e02bab2
to
b68543f
Compare
fruffy
force-pushed
the
fruffy/testgen_dropped_packet_only
branch
from
b68543f
to
0a57c9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to P4Testgen to only generate tests where the packet is dropped. This PR also shows the benefits of the new API. We can now write targeted gtests to exercise a feature. Very useful!
I added tests for both
--dropped-packet-onlyand--output-packet-only.