Add IR utility that helps with return of multiple statements from Transform #4414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
force-pushed
the
irutils-inline-block
branch
2 times, most recently
from
dcb23a5
to
de68fee
Compare
fruffy
reviewed
Feb 12, 2024
asl
reviewed
Feb 12, 2024
vlstill
force-pushed
the
irutils-inline-block
branch
from
0844bbb
to
c49a6df
Compare
vlstill
force-pushed
the
irutils-inline-block
branch
from
c49a6df
to
c747f6f
Compare
asl
reviewed
Feb 12, 2024
ChrisDodd
reviewed
Feb 13, 2024
|
The way I've dealt with this in other passes is to just return a BlockStatement then use SimplifyControlFlow, but this is more efficient. |
fruffy
approved these changes
Feb 13, 2024
| return new IR::IndexedVector<IR::StatOrDecl>(std::forward<Stmts>(stmts)); | ||
| } | ||
| Util::SourceInfo srcInfo; | ||
| if (stmts.size() > 0) { // no .empty in initializer_list! |
There was a problem hiding this comment.
std::empty? I guess that won't work for the other two...
There was a problem hiding this comment.
It should work for anything that has .empty or c-style array and on initializer_list. But I could not decide if it is nicer or uglier than size() > 0.
vlstill
force-pushed
the
irutils-inline-block
branch
from
d1bcc8d
to
cf5c8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of use is in the test: https://github.com/p4lang/p4c/pull/4414/files#diff-c05e1bbc752f9a1299cec11e3e39374bcd48de0eb2939bdca8b4fca6c0aa65d8R51.