[P4Testgen] Fix failing P4Testgen gtest. #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/gtest_fix
branch
from
912dfe0
to
7b55502
Compare
|
What is the cause of the change? With just the change, I am not able to check this is a correct fix. |
|
In #4387 I flattened |
fruffy
force-pushed
the
fruffy/gtest_fix
branch
from
7b55502
to
349995e
Compare
kfcripps
approved these changes
Feb 7, 2024
fruffy
force-pushed
the
fruffy/gtest_fix
branch
from
349995e
to
26bd668
Compare
fruffy
force-pushed
the
fruffy/gtest_fix
branch
from
26bd668
to
5222e0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed fixing a check in #4387.
std:vectorstd::vector> was flattened into std::vector<>, which is why this check is failing. We have a structure of
[a,b,c]instead of[[a,b,c]]now.