-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::allocator_traits::rebind_alloc instead of std::allocator::rebind #4373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks!
Do we need an |
Both of P4C's build tools (CMake and Bazel) require C++17 and the corresponding compilers as minimum version. It was introduced with this PR: #3547. Over the past year no one has raised any concerns. |
a3434a0
to
025c49a
Compare
…bind the latter is deprecated as of C++17 and removed as of C++20
025c49a
to
41b2a0c
Compare
The latter is deprecated in C++17 and removed in C++20.