Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit the Protobuf header with the P4 entries and runtime files. #4350

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Emit the Protobuf header with the P4 entries and runtime files. #4350

merged 2 commits into from
Jan 23, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jan 22, 2024

Fixes #4070.

@fruffy fruffy added p4runtime control-plane Topics related to the control-plane or P4Runtime. labels Jan 22, 2024
smolkaj
smolkaj approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks!

Ideally we would have some golden test for this, if it's easy to add?

@fruffy
Copy link
Collaborator Author

fruffy commented Jan 22, 2024 •
edited
Loading

Amazing, thanks!

Ideally we would have some golden test for this, if it's easy to add?

We do have them already. All BMv2 programs are golden-tested using reference files. Just waiting to see which runs fail.

@fruffy fruffy force-pushed the fruffy/protobuf_header branch 3 times, most recently from e2e9506 to c778be5 Compare January 23, 2024 16:49
jafingerhut
jafingerhut approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may win the award for most files touched in one p4c PR, at least for the last 2 years or so! :-)

LGTM

@fruffy fruffy enabled auto-merge (squash) January 23, 2024 18:22
@fruffy fruffy merged commit c11d28e into main Jan 23, 2024
13 checks passed
@fruffy fruffy deleted the fruffy/protobuf_header branch January 23, 2024 19:22
@fruffy fruffy mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

@smolkaj smolkaj smolkaj approved these changes

Assignees
No one assigned
Labels
control-plane Topics related to the control-plane or P4Runtime.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include header in text proto files
3 participants
@fruffy @jafingerhut @smolkaj