Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger CI workflows based on assigned label. #4348

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jan 22, 2024

This PR does two things.

First, it adds a mechanism to optionally trigger certain CI runs (sanitizers, ubuntu18, validation) by adding the corresponding label to the PR.

Second, it makes the installation of Python packages for Protobuf subject to the Python version. This way we can install the correct version of a Python package depending on the version being used. This fixes the Ubuntu 18 build issues.

@fruffy fruffy added run-sanitizer Use this tag to run a Clang+Sanitzers CI run. and removed run-sanitizer Use this tag to run a Clang+Sanitzers CI run. labels Jan 22, 2024
@fruffy fruffy added run-sanitizer Use this tag to run a Clang+Sanitzers CI run. run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. and removed run-sanitizer Use this tag to run a Clang+Sanitzers CI run. labels Jan 22, 2024
@fruffy fruffy added the run-validation Use this tag to trigger a Validation CI run. label Jan 23, 2024
@fruffy fruffy added run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. and removed run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. labels Jan 23, 2024
@fruffy fruffy force-pushed the fruffy/trigger_nightly branch 2 times, most recently from 45027ca to 75d6906 Compare January 23, 2024 17:56
@fruffy fruffy marked this pull request as ready for review January 23, 2024 18:51
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the intent is that ubuntu-18 CI runs will run nightly, and on any PRs with the 'run-buntu18' label? And similarly for a couple of other nightly CI tests? If so, looks good to me.

@fruffy fruffy merged commit 90ef642 into main Jan 24, 2024
16 checks passed
@fruffy fruffy deleted the fruffy/trigger_nightly branch January 24, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-sanitizer Use this tag to run a Clang+Sanitzers CI run. run-ubuntu18 Use this tag to trigger a Ubuntu-18 CI run. run-validation Use this tag to trigger a Validation CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants