[P4Testgen] Refactor ProgramInfo to be initialized with CompilerResult instead of a IR::P4Program #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/compiler_info_1
branch
from
e437009
to
be3c6bd
Compare
fruffy
force-pushed
the
fruffy/compiler_info_2
branch
from
73b8845
to
63ed3b9
Compare
fruffy
force-pushed
the
fruffy/compiler_info_1
branch
2 times, most recently
from
e9a24db
to
227ff4d
Compare
fruffy
force-pushed
the
fruffy/compiler_info_2
branch
from
63ed3b9
to
c850369
Compare
fruffy
force-pushed
the
fruffy/compiler_info_2
branch
from
c850369
to
97f0b13
Compare
vlstill
reviewed
Jan 12, 2024
| class Bmv2V1ModelCompilerTarget : public CompilerTarget { | ||
| public: | ||
| /// Registers this target. | ||
| static void make(); | ||
|
|
||
| /// @returns the singleton instance for the current target. | ||
| static const Bmv2V1ModelCompilerTarget &get(); |
There was a problem hiding this comment.
The singleton was not there before?
fruffy
force-pushed
the
fruffy/compiler_info_2
branch
5 times, most recently
from
7376777
to
a9121c7
Compare
vlstill
reviewed
Jan 15, 2024
backends/p4tools/modules/testgen/targets/bmv2/test/BMV2MetadataXfail.cmake
Show resolved
Hide resolved
vlstill
approved these changes
Jan 15, 2024
…stead of a IR::P4Program.
fruffy
force-pushed
the
fruffy/compiler_info_2
branch
from
a9121c7
to
48c31ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4323 and introduces the CompilerResult data structure to the ProgramInfo class.
It also introduces the BMv2CompilerResult, which also contains the P4Rutime API for the program. This API is computed in the mid end for this target.