[P4Testgen] Fix append and prepend invocation. #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/testgen_append_prepend
branch
from
1e9ef73
to
780436b
Compare
fruffy
force-pushed
the
fruffy/testgen_append_prepend
branch
from
780436b
to
74b4d39
Compare
fruffy
force-pushed
the
fruffy/testgen_append_prepend
branch
from
74b4d39
to
6ea81f1
Compare
|
@vlstill Don't want to burden you with too many requests but this one has been stuck for a while. |
vlstill
reviewed
Feb 13, 2024
backends/p4tools/modules/testgen/core/small_step/extern_stepper.cpp
Outdated
Show resolved
Hide resolved
fruffy
force-pushed
the
fruffy/testgen_append_prepend
branch
from
6ea81f1
to
e26c2c4
Compare
fruffy
force-pushed
the
fruffy/testgen_append_prepend
branch
from
e26c2c4
to
0a85b96
Compare
fruffy
force-pushed
the
fruffy/testgen_append_prepend
branch
from
0a85b96
to
8fc39bb
Compare
|
@vlstill Can you give this another look? |
vlstill
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pkotikal This should help with the problems you have encountered in 689e013#r135134661
Since we are recording an expression, fix also the way we print expressions. I should implement a more disciplined way to format these inputs without introducing linebreaks.