[P4Testgen] Add support for @format annotations in P4 programs for protobuf-ir tests #4276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy-g
force-pushed
the
fruffy/sai_tests
branch
2 times, most recently
from
7ba119f
to
a06a95a
Compare
fruffy-g
force-pushed
the
fruffy/sai_tests
branch
from
a06a95a
to
5c4ccf9
Compare
fruffy-g
force-pushed
the
fruffy/sai_tests
branch
from
5c4ccf9
to
29187d4
Compare
smolkaj
approved these changes
Dec 18, 2023
backends/p4tools/modules/testgen/targets/bmv2/test_backend/protobuf_ir.cpp
Show resolved
Hide resolved
backends/p4tools/modules/testgen/targets/bmv2/test_backend/protobuf_ir.cpp
Outdated
Show resolved
Hide resolved
fruffy-g
force-pushed
the
fruffy/sai_tests
branch
from
29187d4
to
25863b0
Compare
fruffy-g
force-pushed
the
fruffy/sai_tests
branch
from
b3d512b
to
2f7c0df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P4 SAI annotations such as
@formatdictate a specific format, which must be respected by P4Testgen when generating Protobuf PDPI tests. Hence, we add a couple utility functions to the Protobuf PDPI test back end to produce the right format in the case that a key has such an annotation.Fixes #4273.