Fix some problems and suggestions found by clang-tidy #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
force-pushed
the
lint-1
branch
3 times, most recently
from
55f5ebb
to
a4e4f0f
Compare
fruffy
approved these changes
Nov 13, 2023
| @@ -51,11 +51,14 @@ struct StringRef { | |||
| len = 0; | |||
| } | |||
| StringRef(const StringRef &a) : p(a.p), len(a.len) {} | |||
| // avoid clang-tidy complaining | |||
| // NOLINTBEGIN(bugprone-unhandled-self-assignment) | |||
There was a problem hiding this comment.
if(this == &a)
return *this;
instead?
There was a problem hiding this comment.
This one is safe to be performed, I'm not sure if the if is worth having in such cases. If the if is there, one would have to wonder why it is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these are found by the clang-tidy static analyzer. At this point, I've been only running in on the headers as this is mainly a byproduct of linting a downstream tool. Some of these changes are in the readability category rather than possible bugs, but I think they are all worth applying.