[P4Testgen] Flatten nesting of BMv2 test back ends and rename the folder appropriately. #4219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy-g
force-pushed
the
testbackend-flatten
branch
from
c1cc327
to
17cd92f
Compare
jonathan-dilorenzo
approved these changes
Nov 6, 2023
| ${CMAKE_CURRENT_SOURCE_DIR}/test/backend/ptf.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/test/backend/stf.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/test/test_backend/ptf.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/test/test_backend/stf.cpp |
There was a problem hiding this comment.
Nit: I think I'd go with just 'backend' here instead of test_backend? But not very important if you have a preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of three PRs dedicated to refactoring the BMv2 testing back ends.
The first PR simply flattens the nesting of the test back end and renames the 'backend' folder appropriately.