Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair the static DPDK PTF tests. #4210

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Repair the static DPDK PTF tests. #4210

merged 2 commits into from
Jan 23, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Oct 29, 2023

Fixes #4204.

bt.testutils.log.info("packet experienced a miss in ct_tcp_table as expected")

bt.testutils.log.info("Attempting to delete all entries in ipv4_host")
# TODO: This code does not seem functional?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jafingerhut I am unable to delete table entries on the P4Runtime interface for the DPDK SoftNIC. Even when I read the entries from the table, then try to delete those exact same entries I am getting a "not found" error. Is this a known issue?

The P4Runtme shell code also has the same issue, but it was never uncovered because it was only ever used on tables with no entries.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can double-check, but if I recall correctly, the current DPDK implementation does not support adding or deleting entries from the control plane specifically for add-on-miss tables. For add-on-miss tables, it only supports adding and deleting entries from the data plane.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good to know. Strangely enough I am able to add entries, but I can not remove them.

@fruffy fruffy marked this pull request as ready for review October 31, 2023 14:13
@fruffy fruffy added the dpdk Topics related to the DPDK back end label Nov 3, 2023
@fruffy
Copy link
Collaborator Author

fruffy commented Jan 23, 2024

@jafingerhut I would like to merge this code before further bitrot sets in. This PR simply cleans up the non-functional PTF DPDK code in the compiler and makes it possible to run it again.

The CI tests remain disabled since we have not been able to solve the nondeterministic failures.

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy fruffy merged commit 45dabff into main Jan 23, 2024
13 checks passed
@fruffy fruffy deleted the fruffy/fix_dpdk_tests branch January 23, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpdk Topics related to the DPDK back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert existing DPDK PTF tests in testdata to the new testing format
2 participants