Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix P4TC issues #4209

Merged
merged 7 commits into from
Oct 26, 2023
Merged

Fix P4TC issues #4209

merged 7 commits into from
Oct 26, 2023

Conversation

komaljai
Copy link
Contributor

Issues addressed -

  1. In the parser generation remove an extraneous semicolon from file include code.
  2. In the parser generated code declare compiler_meta struct:
    struct pna_global_metadata *compiler_meta__ = (struct pna_global_metadata *) skb->cb;
  3. Make generated template file to have executable permissions
  4. Generate template file by default (should have same name as pipeline)
  5. Generate the introspection file by default with the SAME name as the pipeline.
  6. Rename kfunc bpf_skb_p4tc_tbl_read to bpf_skb_p4tc_tbl_read
  7. Move declaration of 'struct hdr_md' from post_parser.cpp to header.h file
  8. Change post_parser.c file name to control_block.c
  9. Remove '-i' and -'c' options.

Copy link
Contributor

@usha1830 usha1830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@usha1830 usha1830 merged commit 65295a8 into p4lang:main Oct 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants