Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Testgen] Only look ahead for the else branch when it is not null. #4191

Merged
merged 1 commit into from
Oct 17, 2023
Merged

[P4Testgen] Only look ahead for the else branch when it is not null. #4191

merged 1 commit into from
Oct 17, 2023

Conversation

fruffy-g
Copy link
Contributor

Also check for null in node coverage.

jonathan-dilorenzo
jonathan-dilorenzo approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@jonathan-dilorenzo jonathan-dilorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smolkaj
smolkaj approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy
Copy link
Collaborator

fruffy commented Oct 15, 2023

@jafingerhut @jnfoster
Are we clear to add @smolkaj and @jonathan-dilorenzo as approved submitters to the compiler, so that they are able to review pull requests etc? Do we have a process for that?

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Oct 15, 2023
@fruffy fruffy merged commit f667c25 into p4lang:main Oct 17, 2023
14 checks passed
@fruffy-g fruffy-g deleted the fix_crash branch December 7, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-dilorenzo jonathan-dilorenzo jonathan-dilorenzo approved these changes

@smolkaj smolkaj smolkaj approved these changes

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fruffy-g @fruffy @jonathan-dilorenzo @smolkaj