Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Testgen] Change PNA port width to 32 instead of 9 #4177

Merged
merged 1 commit into from
Sep 29, 2023
Merged

[P4Testgen] Change PNA port width to 32 instead of 9 #4177

merged 1 commit into from
Sep 29, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Sep 28, 2023

Some stale BMv2 code caused a type mismatch.

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Sep 28, 2023
jafingerhut
jafingerhut approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafingerhut jafingerhut merged commit 488f748 into main Sep 29, 2023
17 checks passed
@fruffy fruffy deleted the fruffy/fix_pna_port_type branch October 1, 2023 14:34
@fruffy fruffy mentioned this pull request Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

@pkotikal pkotikal pkotikal approved these changes

@jnfoster jnfoster Awaiting requested review from jnfoster

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruffy @jafingerhut @pkotikal