Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Automatic Exec Groups by adding a toolchain parameter to the affected actions #4116

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

kotlaja
Copy link
Contributor

@kotlaja kotlaja commented Aug 23, 2023

This is a step forward for the full migration of Automatic Exec Groups (AEGs). This change will be effective once AEGs are enabled.

Goal of this migration:

  • Each toolchain type should have its own execution platform. Before this change, the execution platform was selected on a rule base, not on a toolchain type base.
  • Each action which uses a tool coming from a toolchain should specify the toolchain type inside ctx.action.{run, run_shell} toolchain attribute.

The affected action uses tools from cpp toolchain. Hence, cpp toolchain is added to the toolchain param.

Copy link
Collaborator

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smolkaj
Copy link
Member

smolkaj commented Aug 23, 2023

Thanks for approving, LGTM.

@fruffy fruffy merged commit 5824a6b into p4lang:main Aug 25, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants