-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eBPF backend: generate P4Runtime files if required #4113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing to also do is add golden tests here. Keep around reference P4Runtime files to check whether the output format is correct.
@tatry Are there existing automated CI tests that check for eBPF whether the output P4Info files contain the expected contents? As far as I know, the P4Info file generation is currently the same regardless of the target, and covers the v1model, PSA, and PNA architectures equally well. |
It depends on architecture:
I think that I can manage with these issues within this PR. |
It is not supported by P4RuntimeSerializer
I've added some P4info files as examples and reference for tests. I think it is ready for re-review now. |
This has 2 approving reviews, and passing all CI tests, so will merge it in as is. If this was too early, sorry for the confusion, and I guess we can create additional issues/PRs to improve things further. |
Allow to generate P4Runtime files by ebpf backend, because options related to them are ignored.
Supports only PSA architecture. For ebpf filer model options for generating P4info files are (still) ignored.