Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Gauntlet validation, sanitizers, and Ubuntu 18 build/test as nightly actions. #4105

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Aug 13, 2023

Save some CI resources on PRs.

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess the resource you are most concerned with reducing here is the time spent waiting while the diffs in a PR are tested?

@fruffy
Copy link
Collaborator Author

fruffy commented Aug 14, 2023

@jnfoster The PR is blocked because validate is a required run. Can you disable it? In general, we should update the required CI runs.

@jafingerhut
Copy link
Contributor

@jnfoster Do you know who the set of people is that has authorization to make the required steps for this to pass CI checks?

If it does not include @fruffy, I would be in favor of adding him to that set. Also anyone else you think would make sense to add to that set.

@fruffy fruffy changed the title Run Gauntlet validation and Ubuntu 18 build/test as nightly actions. Run Gauntlet validation, sanitizers, and Ubuntu 18 build/test as nightly actions. Oct 5, 2023
@jnfoster
Copy link
Contributor

jnfoster commented Oct 6, 2023

After discussing with the (informal) p4c maintainers, I've bumped up @fruffy's privileges on this repository. He should be able to modify CI configuration settings now.

@fruffy
Copy link
Collaborator Author

fruffy commented Oct 6, 2023

After discussing with the (informal) p4c maintainers, I've bumped up @fruffy's privileges on this repository. He should be able to modify CI configuration settings now.

Thank you!

@fruffy fruffy merged commit 6fc17bd into main Oct 6, 2023
14 checks passed
@fruffy fruffy deleted the fruffy/ci_nightly branch October 6, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants