Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GoogleTest and install it via FetchContent #4092

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Update GoogleTest and install it via FetchContent #4092

merged 2 commits into from
Aug 6, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Aug 2, 2023 •
edited
Loading

  • Update the GoogleTest version we are using, it was almost 6 years old which makes using newer features difficult.
  • Also use FetchContent to pull it in.
  • Remove some BMv2 code from the top-level gtest folder. It should be in the back end.
  • Fix up some includes since GTEST is not always enabled.

@fruffy fruffy changed the title Update GoogleTest and install it via FetchContent. Update GoogleTest and install it via FetchContent Aug 2, 2023
@fruffy fruffy marked this pull request as ready for review August 6, 2023 11:38
jnfoster
jnfoster approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruffy fruffy merged commit be3c04d into main Aug 6, 2023
15 checks passed
@fruffy fruffy deleted the fruffy/gtest_fetchcontent branch August 6, 2023 13:10
@fruffy fruffy mentioned this pull request Aug 6, 2023
Closed
@jafingerhut jafingerhut mentioned this pull request Aug 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster approved these changes

@pkotikal pkotikal Awaiting requested review from pkotikal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @jnfoster