Fix #4067: Add static casts required by newer versions of G++ #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code updates suggested by Fabian Ruffy, and verified by building with these changes on a Fedora 37 Linux system running G++ 12.3.1.
|
In case anyone is curious to see the versions of some P4-open-source-tool-relevant build tools installed by default using the packages available on several versions of Ubuntu and Fedora Linux, I have summarized them in a Google sheet here: https://docs.google.com/spreadsheets/d/1uPde_2sLvX-Ek-Xj_ZaC3NrOa-CZ7_n-Hcox_dQ_VCc |
mihaibudiu
approved these changes
Jul 19, 2023
fruffy
approved these changes
Jul 19, 2023
Maybe instead of a Google doc we can add this to a wiki in the compiler? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code updates suggested by Fabian Ruffy, and verified by building with these changes on a Fedora 37 Linux system running G++ 12.3.1.