Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the dash-pipeline programs. #4060

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jul 11, 2023

Add the PNA version of the dash program, too.

@jafingerhut
Copy link
Contributor

This PR has conflicts that must be resolved. I don't know the root cause of the failing CI builds, but at least resolving the conflicts would trigger running them again, and we can see what fails with latest version of repo rather than the last run which appears to be over a month ago.

@fruffy
Copy link
Collaborator Author

fruffy commented Aug 14, 2023

This PR has conflicts that must be resolved. I don't know the root cause of the failing CI builds, but at least resolving the conflicts would trigger running them again, and we can see what fails with latest version of repo rather than the last run which appears to be over a month ago.

The failures happen because I did not update the reference files for the updated dash program. Once the dash program is fixed, I will update this PR again.

@fruffy fruffy force-pushed the fruffy/dash_pipeline_update branch from 93eb400 to 28a2bba Compare October 3, 2023 13:50
@jafingerhut
Copy link
Contributor

Maybe this is already there and I missed it, but it might be nice to have a README file in the p4_16_samples/dash directory that describes exact steps that can be used to create the version of the DASH P4 code in this commit, e.g. something like:

git clone https://github.com/sonic-net/DASH
cd DASH
git checkout some_commit_SHA_value

plus any p4test command with -DDEFINE_ME options that I am guessing you might have used?

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafingerhut
Copy link
Contributor

Does p4testgen give some kind of error, or cause CI tests to fail, if the "dead code" is left in? I see you have it commented out.

@fruffy
Copy link
Collaborator Author

fruffy commented Oct 3, 2023

No, no in this case. It just does not achieve 100% coverage for the DPDK program. We can undo this with the next refresh, if desired.

@fruffy fruffy merged commit 44bf90f into main Oct 3, 2023
17 checks passed
@fruffy fruffy deleted the fruffy/dash_pipeline_update branch October 3, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants