-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the dash-pipeline programs. #4060
Conversation
This PR has conflicts that must be resolved. I don't know the root cause of the failing CI builds, but at least resolving the conflicts would trigger running them again, and we can see what fails with latest version of repo rather than the last run which appears to be over a month ago. |
The failures happen because I did not update the reference files for the updated dash program. Once the dash program is fixed, I will update this PR again. |
93eb400
to
28a2bba
Compare
Maybe this is already there and I missed it, but it might be nice to have a README file in the p4_16_samples/dash directory that describes exact steps that can be used to create the version of the DASH P4 code in this commit, e.g. something like:
plus any |
28a2bba
to
4aa960f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does p4testgen give some kind of error, or cause CI tests to fail, if the "dead code" is left in? I see you have it commented out. |
No, no in this case. It just does not achieve 100% coverage for the DPDK program. We can undo this with the next refresh, if desired. |
Add the PNA version of the dash program, too.