Fix race condition for parallel PTF nanomsg tests by using network namespaces. #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/fix_ptf_nn_racecondition
branch
from
746a9d9
to
73eb528
Compare
fruffy
changed the title
|
I am not the right person to review ptf programs, you may ask contributors to the ebpf backend, they wrote many |
This is a problem I introduced with #3951 unrelated to the PTF programs in the eBPF back end. The issue is that race conditions can occur when two tests bind to the same port and the existing solution of checking available ports does not seem work. Since the tests are not contained in namespaces one of the programs will fail. This PR just hotfixes this regression so that other PRs can pass. |
mihaibudiu
approved these changes
Jun 20, 2023
backends/bmv2/run-bmv2-ptf-test.py
Outdated
| "---------------------- Creating a namespace ----------------------", | ||
| ) | ||
| random.seed(datetime.now().timestamp()) | ||
| bridge = Bridge(str(random.randint(0, sys.maxsize))) |
There was a problem hiding this comment.
wouldn't a guid be safer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The P4Tools PTF tests using nanomsg are failing because the device ID and TCP ports are conflicting during parallel execution.
Use network namespaces as a bandaid to avoid the spurious CI failures until I find a better solution.