Remove old ipaddr python module #4037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently behavioral-model simple_switch removed this as a dependency, and it seems like that p4c only needed it because of that.
|
The Python package ipaddr has been superseded by ipaddress: https://pypi.org/project/ipaddr/ Its use has been removed from p4lang/behavioral-model code recently: p4lang/behavioral-model@7a8843f It would be nice to remove its use from other p4lang repos where it is mentioned, too, including p4c. |
mihaibudiu
approved these changes
Jun 19, 2023
|
I believe the failures are because the @rst0git how do you maintain this package? Any way we can help? |
|
@fruffy Thank you for the heads-up. I will update the packages in the next few hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.