Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dpdk Backend: Fixed target_name and action parameter bitwidth #4025

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Dpdk Backend: Fixed target_name and action parameter bitwidth #4025

merged 2 commits into from
Jun 14, 2023

Conversation

usha1830
Copy link
Contributor

Fixes the following:

  1. The "target_name" attribute in context json is incorrectly prefixed with control block name. This is not required as the external name of the table is captured in "name" attribute"
  2. Fixed the bitwidth of action parameters as DPDK target needs all metadata to be byte aligned. The bitwidth is updated to 32 if the original bitwidth is <32, 64 otherwise.

@usha1830 usha1830 force-pushed the ctxtBitwidthTblName branch 3 times, most recently from c5facef to 99091e4 Compare June 13, 2023 07:52
@usha1830 usha1830 requested review from hanw and mihaibudiu June 14, 2023 03:28
@usha1830 usha1830 merged commit 31efd57 into p4lang:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbolvansky davidbolvansky davidbolvansky left review comments

@mihaibudiu mihaibudiu mihaibudiu approved these changes

@hanw hanw Awaiting requested review from hanw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usha1830 @mihaibudiu @davidbolvansky