Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4Testgen] Open up P4Testgen interface. #4014

Merged
merged 3 commits into from
May 31, 2023

Conversation

fruffy-bfn
Copy link
Contributor

@fruffy-bfn fruffy-bfn commented May 25, 2023

  • Add PRIVATE/PUBLIC labels to CMake library dependencies in the P4Tools framework.
  • Remove getPortNumWidthBits and replace it with the constants in the respective back ends.
  • Remove the seed as parameter from the back end implementation. That should be inferred from the options class.
  • Make FinalState a movable class by replacingconst Model & with std::reference_wrapper<const Model>.
  • Introduce a helper function in the testgen.cpp class.

@vlstill This PR makes some API changes, test backends will not have a seed argument and instead grab it from the static options class and getPortNumWidthBits is replaced by referencing a constant instead.

@fruffy fruffy added the p4tools Topics related to the P4Tools back end label May 26, 2023
@fruffy-bfn fruffy-bfn marked this pull request as ready for review May 31, 2023 17:51
Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick review, but looks good!

@@ -1,3 +1,3 @@
# The P4Tools repository is owned by the following maintainers.
backends/p4tools @fruffy @pkotikal @jnfoster @mbudiu-vmw
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@fruffy fruffy merged commit b7d62b4 into p4lang:main May 31, 2023
@fruffy-bfn fruffy-bfn deleted the fruffy/testgen_interface branch May 31, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants