Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Testgen] Fix small issues with metadata test backend. Add more functions to IR utilities. Merge default value function. #4004

Merged
merged 7 commits into from
May 15, 2023
Merged

[P4Testgen] Fix small issues with metadata test backend. Add more functions to IR utilities. Merge default value function. #4004

merged 7 commits into from
May 15, 2023

Conversation

fruffy-bfn
Copy link
Contributor

@fruffy-bfn fruffy-bfn commented May 4, 2023 •
edited
Loading

  • Merge the defaultValue from defaultValues.h with getDefaultValue from irutils.h
  • Fix up small issues with the metadata collection test back ends. Also collect the parser states that were traversed.
  • Clean up some incorrect naming after the expanding coverage from IR statements to IR nodes.
  • Do not use source info for coverage sets, instead use the clone id.
  • Move the inja submodule initialization into the testgen extension.
  • Fix incorrect variable setting in the CMake test backend files.
  • Implement a cache for the CoverableNodesScanner to avoid redundant computation.

@fruffy-bfn fruffy-bfn changed the title Fix small issues with metadata test backend. Add more functions to IR utilities. Merge default value function. [P4Testgen] Fix small issues with metadata test backend. Add more functions to IR utilities. Merge default value function. May 5, 2023
@fruffy fruffy added the p4tools Topics related to the P4Tools back end label May 5, 2023
@fruffy-bfn fruffy-bfn force-pushed the metadata_tests branch 2 times, most recently from 782448e to 9a6977e Compare May 12, 2023 23:56
@fruffy-bfn fruffy-bfn marked this pull request as ready for review May 15, 2023 15:15
jnfoster
jnfoster approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fruffy fruffy merged commit 38ba8df into p4lang:main May 15, 2023
@fruffy-bfn fruffy-bfn deleted the metadata_tests branch May 15, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster approved these changes

@fruffy fruffy Awaiting requested review from fruffy

@pkotikal pkotikal Awaiting requested review from pkotikal

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fruffy-bfn @jnfoster @fruffy