Fix initialization-order-fiasco of P4CoreLibrary instance #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
Apr 28, 2023
ChrisDodd
force-pushed
the
cdodd-init-order
branch
from
5d2a85c
to
858850f
Compare
Replaced the usage of static variable P4CoreLibrary::instance by static method P4CoreLibrary::instance(). This static method returns the static variable of P4CoreLibrary instance. Now the core library instance is created in one place irrespective of the order of its usage across several source files. Thus it prevents the initialization-order-fiasco for P4CoreLibrary instance.
ChrisDodd
force-pushed
the
cdodd-init-order
branch
from
858850f
to
f98b25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change from an internal repo that should be in the open source code.