p4tool: Fix build with Z3 installed in non-standard path #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that it is visible when declaring any library under p4tools
This fixes build with Z3 installed to non-standard locations.
vlstill
requested review from
fruffy,
pkotikal,
jnfoster and
mihaibudiu
as code owners
vlstill
commented
Mar 20, 2023
fruffy
approved these changes
Mar 20, 2023
| @@ -34,6 +34,19 @@ project(P4TOOLS VERSION ${P4C_SEM_VERSION_STRING}) | |||
| # inherit FindLibGc. | |||
| list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") | |||
|
|
|||
| # We need a fairly recent version of Z3. | |||
| set(Z3_MIN_VERSION "4.8.14") | |||
| # But 4.12+ is currently broken with libGC | |||
There was a problem hiding this comment.
This is kinda unfortunate. Is this issue reported somewhere?
There was a problem hiding this comment.
Fabian would know more, see also #3930 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build with Z3 in non-standard location & it also improves documentation of the FindZ3 cmake module.