add a feature to control logging via an annotation on annotated IR ob… #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about a test case using these? |
mihaibudiu
approved these changes
Feb 9, 2023
|
Don't forget to clang-format |
hanw
force-pushed
the
hanw/logging-annotation
branch
2 times, most recently
from
e6d0fa5
to
87c6e94
Compare
hanw
force-pushed
the
hanw/logging-annotation
branch
from
87c6e94
to
9fff857
Compare
hanw
requested review from
fruffy,
pkotikal,
vhavel and
jnfoster
as code owners
hanw
force-pushed
the
hanw/logging-annotation
branch
3 times, most recently
from
3b2bf30
to
b373aac
Compare
|
If you install pip3 install --user "clang-format==15.0.4" and then run The MacOS tests are failing for an unrelated reason, which needs to be fixed. |
hanw
force-pushed
the
hanw/logging-annotation
branch
from
b373aac
to
9250634
Compare
|
Looks like the macos issue is gating a few other PRs as well? |
|
I think right now PRs can still be merged despite the test failing. |
hanw
force-pushed
the
hanw/logging-annotation
branch
from
2978dc1
to
3a9f711
Compare
hanw
force-pushed
the
hanw/logging-annotation
branch
from
3a9f711
to
0f28a16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ject only
To use this feature, backend can set the enableLoggingGlobally to false based on a command line flag or a custom annotation, and set the enableLoggingInContext to true on the annotated IR class.
This helps to filter excessive logging in our backend to focus on certain instance of IR class that is touched by a pass.