Fix flawed code in up4.p4 and the pins switch models. #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
requested review from
pkotikal,
vhavel,
jnfoster and
mihaibudiu
as code owners
| @@ -736,7 +736,9 @@ control PreQosPipe(inout parsed_headers_t hdr, inout local_metadata_t local_meta | |||
| } | |||
| } | |||
| } | |||
| Routing.apply(hdr, local_meta, std_meta); | |||
| if (hdr.ipv4.isValid()) { | |||
There was a problem hiding this comment.
Won't it be better if Routing control checks if the header is valid?
I would assume Acl control would need the same check too ...
There was a problem hiding this comment.
Done. For ACL, I believe BMv2 will not match if one of the keys is from an invalid header, but it is better to be safe.
pkotikal
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
up.p4was not checking whether the IPv4 header is valid before applying the routing control, which reads from the IPv4 header.The PINS programs uses the
p4runtime_translationannotation, which is currently not supported by PI (p4lang/PI#585).