Simplify constant-fold method #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Radostin Stoyanov <[email protected]>
rst0git
force-pushed
the
constantfolding
branch
from
c86726a
to
d08b5a6
Compare
mihaibudiu
approved these changes
Jan 6, 2023
| auto structType = type->to<IR::Type_StructLike>(); | ||
| if (structType == nullptr) BUG("Expected a struct type, got %1%", type); | ||
|
|
||
| if (auto list = expr->to<IR::ListExpression>()) { |
There was a problem hiding this comment.
I wonder whether this is still necessary; the type checker will convert list expressions to structexpressions when needed.
There was a problem hiding this comment.
Thank you Mihai for the code review! To avoid the risk of breaking something, I would leave it as is for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to follow up on #3794 to simplify
DoConstantFolding::postorder(IR::Member* e)by removing unnecessary if-else statements.