Move timer from testgen to lib folder. #3785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
requested review from
pkotikal,
vhavel,
jnfoster and
mihaibudiu
as code owners
fruffy
force-pushed
the
fruffy/timer
branch
7 times, most recently
from
8d521bc
to
5b0f690
Compare
|
@mbudiu-vmw Could you give this an approval/review? |
mihaibudiu
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the ScopedTimer class of P4Tools into the general lib folder. A scoped timer measures and logs the lifetime of the timer object from creation to destruction. This is a handy class as it only needs to be instantiated to record the time some functions take.