-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPDK Backend: Register extern support for bfrt.json #3711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really qualified to review the bfruntime changes, so I cannot approve this.
There are lots of whitespace changes, ideally these should be a separate PR, but there's no point making one one. Is this from clang-format?
Yes the whitespace changes are coming from clang-format |
Adding @swaroopsarma working on the https://github.com/p4lang/p4-dpdk-target which is consuming the output bfrt.json |
I dont have privilege to approve this request but the run time changes are as per the requested format which is adhering to the requirements |
There are some changes to testgen, which is why some users are required as reviewers. Can you revert those changes? They seem benign. |
I reverted the changes in testgen directory |
Closing this PR as there are unrelated formatting changes after multiple runs of different versions of clang-format. Created a new PR for the same with just the relevant changes. |
This PR adds support for register extern in bfrt.json.
A new table is emitted for the register instance. This is as expected by the p4-dpdk-target.