Migrate P4Testgen tooling to core P4C (IWYU, clang-format, cpplint, clang-tidy, git hooks) #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Permissions. Small updates.
fruffy
force-pushed
the
fruffy/tooling
branch
2 times, most recently
from
c5b1af5
to
6eefb32
Compare
Perms.
fruffy
force-pushed
the
fruffy/tooling
branch
from
6eefb32
to
3455faa
Compare
fruffy
force-pushed
the
fruffy/tooling
branch
from
0063552
to
c4a04cd
Compare
Git hooks.
fruffy
requested review from
pkotikal,
vhavel,
jnfoster and
mihaibudiu
as code owners
mihaibudiu
approved these changes
Nov 6, 2022
| @@ -29,7 +29,6 @@ set (BMV2_SIMPLE_SWITCH_SRCS | |||
| simple_switch/simpleSwitch.h | |||
| simple_switch/options.h | |||
| ) | |||
| add_cpplint_files (${CMAKE_CURRENT_SOURCE_DIR} "${BMV2_SIMPLE_SWITCH_SRCS}") | |||
There was a problem hiding this comment.
Are these still checked?
There was a problem hiding this comment.
They are checked by a new CI run now. It should actually more thorough than what we had before because you do not have to manually add files for linting any more.
We are adding yet another CI test, but, thankfully, this one only takes about 1-2 minutes.
backends/ubpf/ubpfTable.cpp
Outdated
| @@ -144,7 +143,8 @@ void UBPFTableBase::emitInstance(EBPF::CodeBuilder *builder, EBPF::TableKind tab | |||
| auto scalar = new UBPFScalarType(tb); | |||
| keyTypeStr = scalar->getAsString(); | |||
| } else if (keyType->is<IR::Type_StructLike>()) { | |||
| keyTypeStr = cstring("struct ") + keyTypeName.c_str();; | |||
| keyTypeStr = cstring("struct ") + keyTypeName.c_str(); | |||
| ; | |||
|
Very nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a couple things.
Open for comments on this one. @davidbolvansky This PR might also be interesting to you.
Fixes #3516.