Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if 'match_kind.exact' is defined when expanding switch statements #3654

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Check if 'match_kind.exact' is defined when expanding switch statements #3654

merged 1 commit into from
Nov 3, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu [email protected]
Fixes #3613

jafingerhut
jafingerhut approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As usual, I reviewed only test cases and expected outputs, not compiler internals.

@mihaibudiu mihaibudiu merged commit 8a411bd into p4lang:main Nov 3, 2022
@mihaibudiu mihaibudiu deleted the issue3613 branch November 3, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

@fruffy fruffy Awaiting requested review from fruffy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing include for core.p4 does not give a decent error message with a switch inside a control
2 participants
@mihaibudiu @jafingerhut