Fix incorrect tests : totalLen field of ipv4 header, action name in add_entry call #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests have some user- defined struct field within the header (testdata/p4_16_samples/psa-example-dpdk-byte-alignment_6.p4, testdata/p4_16_samples/psa-example-dpdk-byte-alignment_8.p4 etc) . This was added for testing byte alignment feature for struct field within header which is initialized using {}. I have not removed such fields, only modified the totalLen field and its usage in the program. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3636.
Also fixes the incorrect action name in add_entry call for few tests