-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PSA include files to match recent changes in version from PSA spec #3618
Update PSA include files to match recent changes in version from PSA spec #3618
Conversation
…spec These are only removing obsolete comments.
@usha1830 FYI. Only removing comments, but just so you know in case it affects anything you are working on. |
@hanw would you mind giving a quick look over this and approve? It is only comment additions and removals, this time. |
@hanw These changes only (a) remove old control plane API comments from psa.p4 include files, which were never really used by anyone anyway, I am pretty sure, and confused several people by their presence, and (b) adds comments for assert and assume extern functions. Would be great if you could take a quick scan and approve this, if it meets with your approval, so I can merge it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@mbudiu-vmw Sorry for the bother. Usha Gupta has reviewed this, and it is only changes in comments. She does not have write access, so it appears her approval is not sufficient for me to merge this. If you do not mind approving it, that would be appreciated. |
These are only removing obsolete comments.