Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow serenum members initializers refer to other serenum members #3617

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Allow serenum members initializers refer to other serenum members #3617

merged 1 commit into from
Oct 25, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu [email protected]

@mihaibudiu
Copy link
Contributor Author

Fixes #3616

apinski-cavium
apinski-cavium approved these changes Oct 25, 2022
View reviewed changes
Copy link

@apinski-cavium apinski-cavium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed my front-end to accept this code now too.
So I am ok with the testcase being accepted.

jafingerhut
jafingerhut approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As usual, I am reviewing the test programs and expected output files, not the changes to p4c code.

@mihaibudiu mihaibudiu merged commit ecea88c into p4lang:main Oct 25, 2022
@mihaibudiu mihaibudiu deleted the issue3616 branch October 25, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

@apinski-cavium apinski-cavium apinski-cavium approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaibudiu @jafingerhut @apinski-cavium