Add a p4-constraints and @refers_to parser to P4Tools. #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no-jira]
OleksandrLetychevskyiIntel
requested review from
fruffy,
pkotikal and
jnfoster
as code owners
[no-jira]
…into Restrictions [no-jira]
fruffy
changed the title
fruffy
changed the title
fruffy
requested changes
Oct 19, 2022
[no-jira]
[no-jira]
[no-jira]
|
I will run this code tomorrow to see whether it is complete. Can you refresh it? |
|
I tried to clean up some of the code but there is lots of work left. This code has a lot of problems. I attached a patch, please apply it. |
fruffy
requested changes
Oct 24, 2022
[no-jira]
[no-jira]
[no-jira]
[no-jira]
fruffy
reviewed
Oct 26, 2022
[no-jira]
fruffy
reviewed
Oct 27, 2022
fruffy
reviewed
Oct 27, 2022
|
I went through the code again, there are still items left to do. I made some comments. Here is a new patch that should be applied. |
|
Another patch. |
OleksandrLetychevskyiIntel
requested a review
from mihaibudiu
as a code owner
|
Another patch set to apply. |
|
Can you update this to the latest changes in master? We should run the gtests to check before merging. |
fruffy
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of p4-constraints for P4Tools , it allows you to convert the expression in string format from the body of the
@entry_restrictionor@refers_toannotation into an IR expression and compose the restrictions for the tool from them.These restrictions are added as preconditions to the P4Tools BMv2 execution.