Fix hdr align #3521
Merged
Fix hdr align #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
approved these changes
Sep 8, 2022
| if ((width & 0x7) != 0) { | ||
| all_hdr_field_aligned = false; | ||
| } | ||
| } |
There was a problem hiding this comment.
and if it's not bit<> you do nothing?
There was a problem hiding this comment.
all fields will be of bit<> type at this point.
Properly discard bits when casting to lower sizes Fix typeMap for constants
Fix formatting
kamleshbhalui
force-pushed
the
fix_hdr_align
branch
from
e429af5
to
ca2f25d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly discard bits when casting to lower sizes
Fix typeMap for constants