Add bazel support for p4c-dpdk compiler #3441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaibudiu
reviewed
Jul 15, 2022
|
This is super cool, thanks for the extension! I don't feel strongly, but I wonder if renaming the LGTM from my side either way. |
mihaibudiu
approved these changes
Jul 15, 2022
There was a problem hiding this comment.
I will wait for the changes suggested by @smolkaj to merge.
1. Use 'p4c_backend' atribute to configure the p4c backend binary used for p4_library rule. The 'p4c-dpdk' compiler can be selected if needed. The default compiler is still 'p4c-bm2-ss'. 2. Added DPDK backend specific bf-rt-schema and context output files. 3. Added pna.p4 into default include path. 4. updated blaze example with dpdk pna program vxlan.p4.
lzhzero
force-pushed
the
zhang_blaze_dpdk
branch
from
c76eb72
to
188d793
Compare
|
Thanks for the suggestion. The PR is now updated. I only changed the user facing blaze rule attribute name, and did not change the internal variable name Please let me know what do you think. Also this PR will close issue #3391 |
|
Beautiful, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made
p4catribute of the p4_library rule configurable, so thep4c-dpdkcompiler can be selected if needed. The defaultcompiler is still
p4c-bm2-ss.Added DPDK backend specific bf-rt-schema and context output files.
Added everything under
p4includefolder into the default include.updated blaze example with dpdk pna program vxlan.p4.
Note: This vxlan.p4 program already exist in
backends/dpdk/examples/vxlan.p4